Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing references to filteringTerms URL both in EntryTypeDefinition… #174

Merged

Conversation

jrambla
Copy link
Contributor

@jrambla jrambla commented Oct 11, 2024

Removing references to filteringTerm URLs in EntryType and in Map schemas

@jrambla jrambla requested review from redmitry and costero-e October 11, 2024 14:52
@mbaudis
Copy link
Member

mbaudis commented Nov 8, 2024

Bumping tis -> @redmitry & @costero-e ...

Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and looks good. I think that as this is non-breaking change, we would need to add this for the milestone 2.1.2, unless you want to add it as 2.2.0 already.

@redmitry
Copy link
Collaborator

This shouldn't' break BN. Nevertheless, Clients should be updated to get filters from the "root" /filtering_terms (BN UI ?).

@costero-e
Copy link
Collaborator

True @redmitry. We are developing the new BN UI and we will take this into account, thanks!

@costero-e costero-e merged commit 09143f2 into clean-up Dec 12, 2024
1 check passed
@costero-e costero-e deleted the clean-up_remove_filteringTerms_from-_config_files branch December 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants