Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect reference in models #197

Open
wants to merge 3 commits into
base: schema-urgent-fixes
Choose a base branch
from
Open

Incorrect reference in models #197

wants to merge 3 commits into from

Conversation

jrambla
Copy link
Contributor

@jrambla jrambla commented Dec 17, 2024

A path with /definitions instead of /#defs exists in runs/endpoints file

@jrambla jrambla added this to the 2.1.2 milestone Dec 17, 2024
@jrambla jrambla requested a review from costero-e December 17, 2024 18:45
@jrambla jrambla changed the title Incorrect reference in run model Incorrect reference in models Dec 17, 2024
costero-e
costero-e approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I looked for more entries with definitions but the other ones belong to vrs or other spec which still suport it. So I believe these are the only files where this change still needed to be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costero-e costero-e costero-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jrambla @costero-e