Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizing "entity" mentions to "entry types". #74

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
##### Example Boolean Response

In this minimal response to the query above the beacon indicates that its default
response is Boolean and that it could interpreted it against the `genomicVariant` entity and in the context of the same Beacon version.
response is Boolean and that it could interpreted it against the `genomicVariant` entry type and in the context of the same Beacon version.

In principle one could launch a Beacon instance using the example response document as a template
in whatever server environment one has at hand. However, a proper Beacon v2
Expand All @@ -45,7 +45,7 @@
"requestedGranularity": "boolean",
"requestedSchemas": [
{
"entityType": "genomicVariant",
"entryType": "genomicVariant",
"schema": "https://progenetix.org/services/schemas/genomicVariant/"
}
],
Expand All @@ -61,7 +61,7 @@
"returnedGranularity": "boolean",
"returnedSchemas": [
{
"entityType": "genomicVariant",
"entryType": "genomicVariant",
"schema": "https://progenetix.org/services/schemas/genomicVariant/"
}
]
Expand Down
2 changes: 1 addition & 1 deletion docs/formats-standards.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

For historical reasons, in the names of entities, parameters and URLs we are following these conventions:

* Entity names: `PascalCase`
* Entry Type names: `PascalCase`
* parameters: `camelCase`
* URI path elements: `snake_case`

Expand Down
6 changes: 3 additions & 3 deletions docs/implementations/org.progenetix.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ of those to its supported responses and provide the results accordingly; it does
if the endpoint was `/beacon/biosamples/` or `/beacon/variants/` etc.

Below is an example for the standard test "small deletion CNVs in the CDKN2A locus, in gliomas"
Progenetix test query, here responding with the matched variants. Exchanging the `entityType`
Progenetix test query, here responding with the matched variants. Exchanging the `entryType`
entry to

* `{ "entityType": "biosample", "schema:": "https://progenetix.org/services/schemas/Biosample/"}`
* `{ "entryType": "biosample", "schema:": "https://progenetix.org/services/schemas/Biosample/"}`

would change this to a biosample response. The example ccan be tested by POSTing this as `application/json`
to `http://progenetix.org/beacon/variants/` or `http://progenetix.org/beacon/biosamples/`.
Expand All @@ -28,7 +28,7 @@ to `http://progenetix.org/beacon/variants/` or `http://progenetix.org/beacon/bio
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "genomicVariant",
"entryType": "genomicVariant",
"schema:": "https://progenetix.org/services/schemas/genomicVariant"
}
]
Expand Down
6 changes: 3 additions & 3 deletions docs/variant-queries.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ in the _EIF4A1_ eukaryotic translation initiation factor 4A1.
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "genomicVariation",
"entryType": "genomicVariation",
"schema:": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/models/json/beacon-v2-default-model/genomicVariations/defaultSchema.json"
}
]
Expand Down Expand Up @@ -134,7 +134,7 @@ parameters.
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "genomicVariation",
"entryType": "genomicVariation",
"schema:": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/models/json/beacon-v2-default-model/genomicVariations/defaultSchema.json"
}
]
Expand Down Expand Up @@ -246,7 +246,7 @@ larger than approx. 5Mb (operational definitions of focality vary between 1 and
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "genomicVariation",
"entryType": "genomicVariation",
"schema:": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/models/json/beacon-v2-default-model/genomicVariations/defaultSchema.json"
}
]
Expand Down
6 changes: 3 additions & 3 deletions framework/json/common/beaconCommonComponents.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
"ListOfSchemas": {
"description": "Set of schemas to be used in the response to a request.",
"items": {
"$ref": "#/definitions/SchemasPerEntity"
"$ref": "#/definitions/SchemasPerEntryType"
},
"type": "array"
},
Expand Down Expand Up @@ -208,10 +208,10 @@
},
"type": "object"
},
"SchemasPerEntity": {
"SchemasPerEntryType": {
"description": "Schema to be used for the requested entry type in the response.",
"properties": {
"entityType": {
"entryType": {
"$comment": "TO REVIEW: Should that refer to a concept definition? Or would that include an undesired dependency to the configuration?",
"example": "Individual",
"type": "string"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
],
"listOfSchemas": [
{
"entityType": "EntryTypeA",
"entryType": "EntryTypeA",
"schema": "entry-typeA-schema-v0.1"
},
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
],
Expand All @@ -58,8 +58,8 @@
"limit": 10,
"skip": 0
},
"schemasPerEntity": {
"entityType": "Individual",
"schemasPerEntryType": {
"entryType": "Individual",
"schema": "ga4gh-phenopacket-individual-v0.1"
}
}
4 changes: 2 additions & 2 deletions framework/json/common/validation/beaconCommonComponents.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
"pagination": {
"$ref": "../beaconCommonComponents.json#/definitions/Pagination"
},
"schemasPerEntity": {
"$ref": "../beaconCommonComponents.json#/definitions/SchemasPerEntity"
"SchemasPerEntryType": {
"$ref": "../beaconCommonComponents.json#/definitions/SchemasPerEntryType"
}
},
"title": "Schema for validating Beacon Common Components examples",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "EntryTypeA",
"entryType": "EntryTypeA",
"schema": "entry-typeA-schema-v0.1"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"apiVersion": "2.0",
"requestedSchemas": [
{
"entityType": "EntryTypeA",
"entryType": "EntryTypeA",
"schema": "entry-typeA-schema-v0.1"
}
]
Expand Down
2 changes: 1 addition & 1 deletion framework/json/requests/requestParameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"additionalProperties": {
"type": "object"
},
"description": "The schema below is a placeholder for a dictionary 'key':'object'. The individual definitions depend on the model (e.g. beacon-v2-default-model) and entity (e.g. `genomicVariant`).",
"description": "The schema below is a placeholder for a dictionary 'key':'object'. The individual definitions depend on the model (e.g. beacon-v2-default-model) and entry type (e.g. `genomicVariant`).",
"properties": {
"$schema": {
"description": "Added here to allow proper validation of the documents w/o providing specific values.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
},
"requestedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
},
"returnedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
},
"requestedSchemas": [
{
"entityType": "dataset",
"entryType": "dataset",
"schema": "dataset-schema-v1.0"
}
]
},
"returnedSchemas": [
{
"entityType": "dataset",
"entryType": "dataset",
"schema": "dataset-schema-v1.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
},
"requestedSchemas": [
{
"entityType": "dataset",
"entryType": "dataset",
"schema": "dataset-schema-v1.0"
}
]
},
"returnedSchemas": [
{
"entityType": "dataset",
"entryType": "dataset",
"schema": "dataset-schema-v1.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"beaconId": "string",
"returnedSchemas": [
{
"entityType": "info",
"entryType": "info",
"schema": "beacon-map-v2.0.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
},
"requestedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
},
"returnedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"beaconId": "string",
"returnedSchemas": [
{
"entityType": "info",
"entryType": "info",
"schema": "beacon-map-v2.0.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"requestParameters": [
{
"entity": "individual",
"entryType": "individual",
"parameters": [
{
"id": "123"
Expand All @@ -32,7 +32,7 @@
],
"requestedSchemas": [
{
"entityType": "Individual",
"entryType": "Individual",
"schema": "ga4gh-phenopacket-individual-v0.1"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"beaconId": "string",
"returnedSchemas": [
{
"entityType": "info",
"entryType": "info",
"schema": "beacon-info-v2.0.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"beaconId": "string",
"returnedSchemas": [
{
"entityType": "info",
"entryType": "info",
"schema": "beacon-info-v2.0.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"beaconId": "string",
"returnedSchemas": [
{
"entityType": "info",
"entryType": "info",
"schema": "beacon-map-v2.0.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
},
"requestedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
},
"returnedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"requestedGranularity": "count",
"requestedSchemas": [
{
"entityType": "Individual",
"entryType": "Individual",
"schema": "ga4gh-phenopacket-individual-v0.1"
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"requestedGranularity": "count",
"requestedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
],
Expand All @@ -20,7 +20,7 @@
"returnedGranularity": "count",
"returnedSchemas": [
{
"entityType": "EntryTypeB",
"entryType": "EntryTypeB",
"schema": "entry-typeB-schema-v1.0"
}
]
Expand Down
2 changes: 1 addition & 1 deletion framework/json/responses/sections/beaconResponseMeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"returnedSchemas": {
"$ref": "../../common/beaconCommonComponents.json#/definitions/ListOfSchemas",
"description": "The `returnedSchemas` parameter indicates that the request has been interpreted for the indicated entity. This helps to disambiguate between negative responses due to e.g. no hit on a well understood request and failures to interpret or answer the request due to a missing entity. "
"description": "The `returnedSchemas` parameter indicates that the request has been interpreted for the indicated entry type. This helps to disambiguate between negative responses due to e.g. no hit on a well understood request and failures to interpret or answer the request due to a missing entry type. "
},
"testMode": {
"$ref": "../../common/beaconCommonComponents.json#/definitions/TestMode"
Expand Down
6 changes: 3 additions & 3 deletions framework/src/common/beaconCommonComponents.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ definitions:
Set of schemas to be used in the response to a request.
type: array
items:
$ref: '#/definitions/SchemasPerEntity'
SchemasPerEntity:
$ref: '#/definitions/SchemasPerEntryType'
SchemasPerEntryType:
description: >-
Schema to be used for the requested entry type in the response.
type: object
properties:
entityType:
entryType:
type: string
example: Individual
$comment: >-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ beaconError:
errorCode: 404
errorMessage: the provided parameters are incomplete. 'xyz' is missing.
listOfSchemas:
- entityType: EntryTypeA
- entryType: EntryTypeA
schema: entry-typeA-schema-v0.1
- entityType: EntryTypeB
- entryType: EntryTypeB
schema: entry-typeB-schema-v1.0
schemasPerEntity:
entityType: Individual
SchemasPerEntryType:
entryType: Individual
schema: ga4gh-phenopacket-individual-v0.1
pagination:
skip: 0
Expand Down
4 changes: 2 additions & 2 deletions framework/src/common/validation/beaconCommonComponents.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ properties:
$ref: ../beaconCommonComponents.yaml#/definitions/BeaconError
listOfSchemas:
$ref: ../beaconCommonComponents.yaml#/definitions/ListOfSchemas
schemasPerEntity:
$ref: ../beaconCommonComponents.yaml#/definitions/SchemasPerEntity
SchemasPerEntryType:
$ref: ../beaconCommonComponents.yaml#/definitions/SchemasPerEntryType
pagination:
$ref: ../beaconCommonComponents.yaml#/definitions/Pagination
includeResultsetResponses:
Expand Down
Loading