Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema urgent fixes #85

Closed
wants to merge 4 commits into from
Closed

Schema urgent fixes #85

wants to merge 4 commits into from

Conversation

costero-e
Copy link
Collaborator

Branch of mixed fixes that can be done straight forward to develop branch because they don't belong to any specific feature. Between those fixes, we can find Handover fix for avoid the verifier to pass beacon tests, adding object type to beacon resultsets, un update in Changelog.md and removing "age" to be a title of diseases.

mbaudis and others added 4 commits May 24, 2023 11:24
`ResultsetInstance` was missing the "type" parameter which leads to errors when creating instances.
This is a pure documentation change for the handover format. Addresses #83
@mbaudis
Copy link
Member

mbaudis commented Jun 12, 2023

@costero-e Fine with me 👍 But generally I'd like to see such non-breaking patch fixes then also propagated to main.

@costero-e
Copy link
Collaborator Author

True @mbaudis, as they are hotfixes I guess we can make the PR right direct to main the next time. If you have any urgency for having them in main branch soon we can PR to main branch, too.

@mbaudis
Copy link
Member

mbaudis commented Jun 12, 2023

@costero-e I'll leave this to you; an important aspect is to have a branch manager w/ "decision power" :-)

(But esp. for the filters doc & the missing object type it is rather important and no downside to have it ASAP; the age part is potentially breaking though nobody should care)

@costero-e
Copy link
Collaborator Author

Hi @mbaudis, you are right that hotfixes have to be merged directly into main. I will close this PR and we will merge the #82 that is already open (sorry for that, I thought it was different). Thank you for the observations.

@costero-e costero-e closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants