removed the example on "numerical" filters, amended a couple of examples #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test changes for the new build workflow from website-docs
test edit
correction of a typo
Update README.md
Documentation: Additional contribution/development pages together with a reorganization of the navigation structure. Also, clarification of the cohorts relation (#80).
More details and examples about the use of filters in various scenarios, including GET examples for age etc. A main change here is the alignment of the filter types w/ the specification (e.g. no separate "numeric" type).
... and fixing `filterTerms` => `filteringTerms`
This is an attempt to get the documentation site towards "clean HTTPS"
* separate pages for records and handovers * navigation restructuring ... more content to follow
see "changes" on the site
Edits have to be done in YAML and then propagated to JSON using bin/yamlerRunner.sh
|
@jrambla Thanks; I had tried to do this e.g. in fca3233 but may have missed some. But you're now merging the documentation into main - which is fine in principle, but not strictly necessary & against the "main branch freeze". No problems from my side, though. Note: one of he fixes directly affects framework, not only docs, so is a true fix in main (not affecting code, just inline examples). And this needs to be done the standard way (edit yaml, run bin/yamlrunner.sh OR manually edit both w/ diligence...) . Fixed in 23d49cc |
mbaudis
approved these changes
Jun 14, 2023
|
we need @tb143 approval here to close this PR |
tb143
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spotted a couple of places where examples seem incorrect.
Also removed the example on "numerical" filters as they do not actually exist.
I've only left the "alphanumerical" one.