-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed the example on "numerical" filters, amended a couple of examples #86
Conversation
Some test changes for the new build workflow from website-docs
test edit
correction of a typo
Update README.md
Documentation: Additional contribution/development pages together with a reorganization of the navigation structure. Also, clarification of the cohorts relation (#80).
More details and examples about the use of filters in various scenarios, including GET examples for age etc. A main change here is the alignment of the filter types w/ the specification (e.g. no separate "numeric" type).
... and fixing `filterTerms` => `filteringTerms`
This is an attempt to get the documentation site towards "clean HTTPS"
* separate pages for records and handovers * navigation restructuring ... more content to follow
see "changes" on the site
Edits have to be done in YAML and then propagated to JSON using bin/yamlerRunner.sh
@jrambla Thanks; I had tried to do this e.g. in fca3233 but may have missed some. But you're now merging the documentation into main - which is fine in principle, but not strictly necessary & against the "main branch freeze". No problems from my side, though. Note: one of he fixes directly affects framework, not only docs, so is a true fix in main (not affecting code, just inline examples). And this needs to be done the standard way (edit yaml, run bin/yamlrunner.sh OR manually edit both w/ diligence...) . Fixed in 23d49cc |
we need @tb143 approval here to close this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numerical filter operators are now subsumed under alphanumerical filter operators.
I've spotted a couple of places where examples seem incorrect.
Also removed the example on "numerical" filters as they do not actually exist.
I've only left the "alphanumerical" one.