Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change beaconFilterinTermsResults type to enum #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change beaconFilterinTermsResults type to enum #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa894b
filtering Terms results response to enum
Jun 16, 2023
59ac149
example is a string
Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions framework/json/responses/sections/beaconFilteringTermsResults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@
],
"type": "string"
},
"type": {
"description": "Either \"custom\", \"alphanumeric\" or ontology/terminology full name. TODO: An ontology ... with a registered prefix does not need a full name so one may better use CURIE to indicate that the resource can be retrieved from the id. This also will allow to provide an enum here.",
"examples": [
"Human Phenotype Ontology",
"alphanumeric"
"type":{
"description": "Either \"custom\", \"alphanumeric\" or \"ontology\" .",
"enum": [
"custom",
"alphanumeric",
"ontology"
],
"example": "alphanumeric",
"type": "string"
}
},
Expand Down
11 changes: 5 additions & 6 deletions framework/src/responses/sections/beaconFilteringTermsResults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,12 @@ definitions:
type:
type: string
description: >-
Either "custom", "alphanumeric" or ontology/terminology full name.
TODO: An ontology ... with a registered prefix does not need a full name
so one may better use CURIE to indicate that the resource can be retrieved
from the id. This also will allow to provide an enum here.
examples:
- "Human Phenotype Ontology"
Either "custom", "alphanumeric" or "ontology" .
enum:
- custom
- alphanumeric
- ontology
example: alphanumeric
id:
description: >-
The field id in the case of numeric or alphanumeric fields, or
Expand Down