Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in spec #387

Merged

Conversation

Shakespeared
Copy link
Contributor

@Shakespeared Shakespeared commented Aug 1, 2022

No functional changes, just typos

#386

@dglazer
Copy link
Member

dglazer commented Sep 12, 2022

Great cleanup, thank you! I'll add a couple of tiny in-line comments.

@@ -15,6 +15,6 @@ properties:
Other values MAY be used, as long as implementors are aware of the issues discussed in https://tools.ietf.org/html/rfc6920#section-9.4[RFC6920].

GA4GH may provide more explicit guidance for use of non-IANA-registered algorithms in the future.
Until then, if implementors do choose such an algorithm (e.g. because it's implemented by their storage provider), they SHOULD use an existing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either spelling is acceptable; I agree "er" is more common

@@ -8,7 +8,7 @@ See the documentation on the [n2t.net](https://n2t.net/e/compact_ids.html) and [

## Calling Meta-Resolver APIs for Compact Identifier-Based DRS URIs

Clients resolving Compact Identifier-based URIs need to convert a prefix (e.g. “drs.42”) into an URL pattern. They can do so by calling either the identifiers.org or the n2t.net API, since the two meta-resolvers keep their mapping databases in sync.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer "an", since I read it to myself as "an earl", not as "a you are ell". But the Web agrees with you (32M vs. 1M).

Copy link
Contributor

@briandoconnor briandoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! Thanks @Shakespeared so much for doing this!!

@briandoconnor briandoconnor merged commit ec56127 into ga4gh:develop Sep 22, 2022
@Shakespeared
Copy link
Contributor Author

This is great!! Thanks @Shakespeared so much for doing this!!

Thanks for reviewing and merging, glad it was helpful! :)

@Shakespeared Shakespeared deleted the feature/issue-386-fix-typos branch November 21, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants