This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Prevent erroneous constraints.txt file checkins #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david4096
reviewed
Feb 15, 2017
| # Then, when the change has been accepted at the common repository | ||
| # you can change this to point back at the master branch! | ||
| # | ||
| # When making a release, these constraints are changed to point at |
There was a problem hiding this comment.
Noting that we specifically opted not to do this at the release. Instead the constraints line is deleted and the pinned version is set in the requirements.txt.
There was a problem hiding this comment.
Something to circle back to when we change our documentation (all of the constraints.txt files should have similar instructions... I just copy and pasted them)
|
Thanks @dcolligan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.