This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
Prevent erroneous constraints.txt file checkins #817
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# This file allows our dependencies to be against specific versions | ||
# or git tags. Each line is similar to a requirements.txt line, | ||
# except that when installing the dependencies, the constraints.txt | ||
# is converted into the `dependency_links` of the setuptools | ||
# packaging script. This allows us to maintain dependencies across | ||
# repositories. | ||
# | ||
# For example, during development we use the development version | ||
# of common with the line: | ||
# | ||
# git+git://github.com/ga4gh/ga4gh-common.git@master#egg=ga4gh_common | ||
# | ||
# When one has proposed a common modification, they can change this | ||
# constraint to point at the branch of their proposed change: | ||
# | ||
# git+git://github.com/david4096/ga4gh-common.git@some-branch#egg=ga4gh_common | ||
# | ||
# Then, when the change has been accepted at the common repository | ||
# you can change this to point back at the master branch! | ||
# | ||
# When making a release, these constraints are changed to point at | ||
# the released dependency. | ||
# | ||
# ga4gh-common==0.1.0 | ||
# | ||
git+git://github.com/ga4gh/ga4gh-common.git@master#egg=ga4gh_common |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
""" | ||
Tests the constraints invariants | ||
""" | ||
from __future__ import division | ||
from __future__ import print_function | ||
from __future__ import unicode_literals | ||
|
||
import unittest | ||
|
||
import ga4gh.common.utils as utils | ||
|
||
|
||
class TestConstraints(unittest.TestCase): | ||
|
||
constraintsFilePath = 'python/constraints.txt' | ||
constraintsFileDefaultPath = 'python/constraints.txt.default' | ||
|
||
def testDefault(self): | ||
utils.assertFileContentsIdentical( | ||
self.constraintsFilePath, self.constraintsFileDefaultPath) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that we specifically opted not to do this at the release. Instead the constraints line is deleted and the pinned version is set in the requirements.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to circle back to when we change our documentation (all of the constraints.txt files should have similar instructions... I just copy and pasted them)