Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Add info to transcript effect record #1334

Closed
david4096 opened this issue Aug 8, 2016 · 5 comments
Closed

Add info to transcript effect record #1334

david4096 opened this issue Aug 8, 2016 · 5 comments
Assignees
@andrewjesaitis
Labels
Schemas
Milestone
2017-00 v0.3.6

Comments

@david4096
Copy link
Member

To go with ga4gh/ga4gh-schemas#648
@kozbo
Copy link
Contributor

kozbo commented Sep 21, 2016

@david4096 #648 is merged. closing

@kozbo kozbo closed this as completed Sep 21, 2016
@david4096 david4096 reopened this Sep 30, 2016
@david4096
Copy link
Member Author

david4096 commented Sep 30, 2016 •
edited
Loading

Let's keep this open unless the feature is implemented in the server. We should demonstrate how keys generated during VCF annotation can be interchanged even if they're not present in the data model as canonical values (IMPACT modifier?).

@david4096 david4096 added this to the v0.3.5 milestone Oct 25, 2016
@david4096 david4096 modified the milestones: v0.3.6, v0.3.5 Nov 3, 2016
@andrewjesaitis
Copy link
Member

Started working on this tonight.

@david4096
Copy link
Member Author

david4096 commented Jan 12, 2017 •
edited
Loading

Awesome!

I just started implementing an upgraded tag bag (info field to attributes). The field is added across the board but I haven't addressed the "other keys" in annotated VCFs yet. Take a look at #1521 . It's pretty painless to switch back and forth between the two. I think we're slowly converging toward a type reflection method that will work for read tags, VCF tags, and random metadata.

andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Jan 18, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation to place extra dat…
d8257d8 
…a in INFO
@andrewjesaitis andrewjesaitis mentioned this issue Jan 18, 2017
Closed
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 9, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation to place extra dat…
a7dad6f 
…a in INFO
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 10, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation to place extra dat…
7721dd6 
…a in INFO
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 10, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation to place extra dat…
6557e25 
…a in INFO
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 10, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation
f492fe5 
* Place extra data in attributes field
* Simplify code path for annotation parsing
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 10, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation
bdc0d7e 
* Place extra data in attributes field
* Simplify code path for annotation parsing
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 14, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation
c2e6a89 
* Place extra data in attributes field
* Simplify code path for annotation parsing
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 14, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation
9b5d326 
* Place extra data in attributes field
* Simplify code path for annotation parsing
andrewjesaitis added a commit to andrewjesaitis/server that referenced this issue Feb 16, 2017
@andrewjesaitis
Fix for ga4gh#1334: Refactor transcript annotation
5792e83 
* Place extra data in attributes field
* Simplify code path for annotation parsing
david4096 pushed a commit that referenced this issue Feb 20, 2017
@andrewjesaitis @david4096
Fix for #1334: Refactor transcript annotation (#1562)
febbfb8 
* Place extra data in attributes field
* Simplify code path for annotation parsing
@david4096
Copy link
Member Author

Closed with #1562

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewjesaitis andrewjesaitis

Labels
Schemas
Projects
None yet
Milestone
2017-00 v0.3.6
Development

No branches or pull requests
3 participants
@andrewjesaitis @david4096 @kozbo