Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

remove feature_id from ExpressionLevel #1574

Merged
merged 6 commits into from
Mar 2, 2017

Conversation

saupchurch
Copy link
Contributor

@saupchurch saupchurch commented Feb 17, 2017

remove feature_id from ExpressionLevel and changes search to filter by name
depends on:
ga4gh/ga4gh-schemas#829

@ejacox
Copy link
Collaborator

ejacox commented Feb 21, 2017

+1

@david4096
Copy link
Member

@saupchurch thanks for taking a look at this! Once the tests are updated I think it will be ready to merge!

@saupchurch
Copy link
Contributor Author

@david4096 thanks. I should have updated test shortly.

@kozbo
Copy link
Contributor

kozbo commented Feb 24, 2017

closes #1580

@ejacox
Copy link
Collaborator

ejacox commented Mar 2, 2017

I removed an unused parameter that was causing one test to fail. The tests pass. However, the constraints file pointing to the correct schemas and client wasn't checked in, so travis is failing here.

Simple changer to force tests to rerun.
simple change to force rerun
@codecov-io
Copy link

Codecov Report

Merging #1574 into master will increase coverage by 0.13%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   85.78%   85.91%   +0.13%     
==========================================
  Files          34       34              
  Lines        7511     7489      -22     
  Branches      944      938       -6     
==========================================
- Hits         6443     6434       -9     
+ Misses        868      857      -11     
+ Partials      200      198       -2
Impacted Files Coverage Δ
ga4gh/server/paging.py 90.57% <ø> (ø)
ga4gh/server/datamodel/rna_quantification.py 89.79% <100%> (-0.13%)
ga4gh/server/repo/rnaseq2ga.py 65.88% <75%> (+3.44%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0276ab0...df2fa3c. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants