This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
remove feature_id from ExpressionLevel #1574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 |
@saupchurch thanks for taking a look at this! Once the tests are updated I think it will be ready to merge! |
@david4096 thanks. I should have updated test shortly. |
closes #1580 |
I removed an unused parameter that was causing one test to fail. The tests pass. However, the constraints file pointing to the correct schemas and client wasn't checked in, so travis is failing here. |
Simple changer to force tests to rerun.
simple change to force rerun
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 85.78% 85.91% +0.13%
==========================================
Files 34 34
Lines 7511 7489 -22
Branches 944 938 -6
==========================================
- Hits 6443 6434 -9
+ Misses 868 857 -11
+ Partials 200 198 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove feature_id from ExpressionLevel and changes search to filter by name
depends on:
ga4gh/ga4gh-schemas#829