Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating README and adding CONFIGURATION.md #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updating README and adding CONFIGURATION.md #47

wants to merge 2 commits into from

Conversation

Chen2x
Copy link

@Chen2x Chen2x commented Jul 22, 2022

No description provided.

@Chen2x Chen2x assigned Chen2x and unassigned Chen2x Jul 22, 2022
@Chen2x Chen2x requested a review from alextsaihi July 22, 2022 15:18
@Chen2x Chen2x linked an issue Jul 22, 2022 that may be closed by this pull request
Update READMEs #46
Open
@alextsaihi
Copy link

@Chen2x , the serverProps and databaseProps in config.md would need to be updated from the old attributes. I'd probably go with the one Yash already completed for us on here

aside from that, I think it looks good

@Chen2x
Copy link
Author

Chen2x commented Aug 3, 2022 •
edited
Loading

@alextsaihi I think I updated to what Yash has. Let me know if any more changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextsaihi alextsaihi Awaiting requested review from alextsaihi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update READMEs
2 participants
@Chen2x @alextsaihi