Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Extension class in common-source.yaml #19

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Updates to Extension class in common-source.yaml #19

merged 1 commit into from
Jun 23, 2024

Conversation

mbrush
Copy link
Contributor

@mbrush mbrush commented Jun 14, 2024

  • updates descriptions of the Extension class and its properties to align with those in the original core-im.
  • added 'value' as a required property (an Extension object is of no use without a value . . . if there is no value available, the data creator should just not create the Extension object in the first place)

@mbrush
Updates to Extension class in common-source.yaml
2fee5c8 
- Updates descriptions of the Coding class and its properties to align with those in the original core-im.
- added 'value' as a required property (an Extension object is of no use without a value . . . if there is no value available, the data creator should just not create the Extension object in the first place))
larrybabb
larrybabb approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I like the addition of the extensionDescription. I'm not sure why we just don't call it description, but I will defer to the semantic guru.

@larrybabb larrybabb merged commit 0571f1d into 1.x Jun 23, 2024
2 checks passed
@larrybabb larrybabb deleted the mbrush-patch-1-Extension-updates branch June 23, 2024 19:27
@mbrush
Copy link
Contributor Author

mbrush commented Jun 25, 2024

re: extensionDescription vs description as a name for this property. I think description is actually fine . . . change if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larrybabb larrybabb larrybabb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrush @larrybabb