change subjectClassificaiton back to classification in the core-im-source.yaml
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing to change `subjectClassification` back to `classification` (despite being the one who suggested the `subjectClassificaiton` in the first place. This is because in the context of Statement profiles like the VariantPathogenicityStatement profile here, we app;y the pattern of renaming the core-im `subject` property by appending the type of thing the subject is - e,g. `subjectVariant` . It is therefore confusing to see an attribute called `subjectClassification`, as it implies that a Classification is the subject of the statement. Lets go back to the simpler name `classification`, and leave it to the attribute description to tell users that this is a classification of the entity representing the Statement's subject. Shoudln't be too controversial as I think this is what LaArry and Alex had called this attribute originally.
larrybabb
approved these changes
Sep 9, 2024
larrybabb
pushed a commit
that referenced
this pull request
Sep 9, 2024
Proposing to change `subjectClassification` back to `classification`. We apply the pattern of renaming the core-im `subject` property by appending the type of thing the subject is - e,g. `subjectVariant`. It is therefore confusing to see an attribute called `subjectClassification`, as it implies that a Classification is the subject of the statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to change
subjectClassificationback toclassification(despite being the one who suggested thesubjectClassificaitonin the first place. This is because in the context of Statement profiles like the VariantPathogenicityStatement profile here, we app;y the pattern of renaming the core-imsubjectproperty by appending the type of thing the subject is - e,g.subjectVariant. It is therefore confusing to see an attribute calledsubjectClassification, as it implies that a Classification is the subject of the statement.Lets go back to the simpler name
classification, and leave it to the attribute description to tell users that this is a classification of the entity representing the Statement's subject.Shoudln't be too controversial as I think this is what LaArry and Alex had called this attribute originally.