Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowercase primitive data types (À la FHIR) #86

Merged
merged 3 commits into from
Nov 7, 2024
Merged

lowercase primitive data types (À la FHIR) #86

merged 3 commits into from
Nov 7, 2024

Conversation

larrybabb
Copy link
Contributor

  • FHIR lowercases "primitive" data types. In the spirit of following that lead GKS would like to have all primitive data types use this styling to help reflect when a "primitive" is being used for a given attribute.
  • add date and datetime primitive types
  • rename IRI to iriReference to reflect that it is actually an iri-reference formatted string per json schema's formats.

ahwagner
ahwagner approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm still not convinced of the need for these additional primitives wrappers. But I see no issue with the way they are implemented.

@larrybabb larrybabb merged commit b65309d into 1.x Nov 7, 2024
2 checks passed
@larrybabb larrybabb deleted the primitive-styling branch November 7, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larrybabb @ahwagner