shot at bringing draft spec up to date with adrs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
May 17, 2023
|
I will merge this to dev to make it easier to see and review this. |
tcezard
reviewed
Aug 23, 2023
Comment on lines
+160
to
+166
| The GA4GH digest algorithm, `sha512t24u`, was created as part of the [Variation Representation Specification standard](https://vrs.ga4gh.org/en/stable/impl-guide/computed_identifiers.html). This procedure is described as ([Hart _et al_. 2020](https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0239883)): | ||
|
|
||
| - performing a SHA-512 digest on a binary blob of data | ||
| - truncate the resulting digest to 24 bytes | ||
| - encodes the 24 bytes using `base64url` ([RFC 4648](https://datatracker.ietf.org/doc/html/rfc4648#section-5)) resulting in a 32 character string | ||
|
|
||
| This converts the value of each attribute in the seqcol into a digest string. Applying this to each value will produce a structure that looks like this: |
There was a problem hiding this comment.
I think this should get its own section so it can be refered to elsewhere like in the sorted_name_length_pairs section
There was a problem hiding this comment.
agreed. would it make sense in a footnote, maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Far from final, but this at least brings a draft specification up-to-date with our current decisions. Take a look if you can but the goal here is to provide a general, one-stop description of seqcol that could be useful to have during Connect.
I do still need to get the 'inherent' stuff in there, though.
TODO: