Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ga4gh_identify to take the ordered property into consideration #116

Closed
korikuzma opened this issue Oct 24, 2022 · 2 comments · Fixed by #118 or #417
Closed

Update ga4gh_identify to take the ordered property into consideration #116

korikuzma opened this issue Oct 24, 2022 · 2 comments · Fixed by #118 or #417
Assignees
@korikuzma
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch priority:high High priority requirement Required

Comments

@korikuzma
Copy link
Contributor

korikuzma commented Oct 24, 2022 •
edited
Loading

@ahwagner added an ordered property in the VRS schemas for array fields. @ahwagner can you comment more on this field?
@korikuzma korikuzma self-assigned this Oct 24, 2022
@ahwagner
Copy link
Member

Yes: the ordered property of an array indicates whether order is meaningful in an array (e.g. in a ComposedSequenceExpression) or not meaningful (e.g. in a Genotype). If ordered == True, then the array elements MUST NOT be sorted during serialization; conversely if ordered == False, then the array elements MUST be sorted during serialization.

korikuzma added a commit that referenced this issue Nov 2, 2022
@korikuzma
feat: digests take ordered property in arrays into consideration (#116)
8be17bf
@korikuzma korikuzma mentioned this issue Nov 2, 2022
Merged
korikuzma added a commit that referenced this issue Nov 8, 2022
@korikuzma
feat: digests take ordered property in arrays into consideration (#116)
32b0d78
korikuzma added a commit that referenced this issue Nov 8, 2022
@korikuzma
feat: digests take ordered property in arrays into consideration (#116)
5ac5798
korikuzma added a commit that referenced this issue Nov 8, 2022
@korikuzma
Merge pull request #118 from ga4gh/issue-116
05b1105 
feat: digests take ordered property in arrays into consideration (#116)
@korikuzma
Copy link
Contributor Author

Re-opening for 2-alpha

@korikuzma korikuzma reopened this Nov 20, 2023
@korikuzma korikuzma added 2.0-alpha Issues related to VRS 2.0-alpha branch requirement Required priority:high High priority labels Nov 20, 2023
@korikuzma korikuzma mentioned this issue Jul 5, 2024
Merged
@korikuzma korikuzma linked a pull request Jul 5, 2024 that will close this issue
feat!: update vrs/common models #417
Merged
korikuzma added a commit that referenced this issue Jul 10, 2024
@korikuzma
feat!: update vrs/common models (#417)
506940e 
close #409 , #116

* updates vrs/gks-common submodules
  * Pydantic models updated to reflect these changes
* Removed `use_enum_values` from Pydantic config. We didn't use this in
all models, so not sure if there was a purpose for it.
* Removed duplicate vrs test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
2.0-alpha Issues related to VRS 2.0-alpha branch priority:high High priority requirement Required
Projects
None yet
Milestone
No milestone
2 participants
@ahwagner @korikuzma