Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order in the readme #291

Closed
korikuzma opened this issue Dec 6, 2023 · 3 comments
Closed

Change order in the readme #291

korikuzma opened this issue Dec 6, 2023 · 3 comments
Assignees
Labels
documentation Changes to documentation only priority:low Low priority

Comments

@korikuzma
Copy link
Contributor

It says "once installed as described above" but this venv and the directory layout venv/<version> is created in the makefile. The makefile step make devready is below in Installing for development. Maybe before the pip install above we should add a step about creating a virtual environment with python3.10 -m venv venv/3.10, or add it to this section.

Should we also put a note that Python 3.10 must be installed? The makefile won't run otherwise.

(I have mixed opinions on tying the makefile to a python version)

Originally posted by @theferrit32 in #288 (comment)

@sivangbagri
Copy link
Contributor

sivangbagri commented Dec 8, 2023

@korikuzma I want to work on this issue , Please Assign .

@korikuzma korikuzma added documentation Changes to documentation only priority:low Low priority labels Dec 8, 2023
@sivangbagri
Copy link
Contributor

@korikuzma Hii , I have made the changes , kindly review

@larrybabb
Copy link
Contributor

Fixed in PR #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to documentation only priority:low Low priority
Projects
None yet
Development

No branches or pull requests

3 participants