Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update + reorganize readme #376

Merged
merged 7 commits into from
Apr 4, 2024
Merged

docs: update + reorganize readme #376

merged 7 commits into from
Apr 4, 2024

Conversation

korikuzma
Copy link
Contributor

close #368

Ideally, in the future we will create a rtd so that our readme isn't so long

@korikuzma korikuzma added documentation Changes to documentation only priority:medium Medium priority labels Mar 29, 2024
@korikuzma korikuzma self-assigned this Mar 29, 2024
@korikuzma korikuzma requested review from a team as code owners March 29, 2024 15:56
README.md Outdated Show resolved Hide resolved
Co-authored-by: James Stevenson <james.sharpsteen@gmail.com>
@korikuzma korikuzma requested a review from jsstevenson March 29, 2024 19:31

- **ga4gh.core package** Python language support for certain nascent standards
in GA4GH. Eventually, this package should be moved to a distinct repo.
## Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korikuzma I think the Features section should not be broken down by module. But instead it should be a bullet list of separate features (see hgvs read.me). I think it is harder to discern the specific features as it feels more technical to go through modules right out of the gate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larrybabb should we be distinguishing between VRS Python features (ie the translator and annotator) and VRS features (a nonambiguous description of variation)? Or maybe bullet point one is like "Pydantic implementation of VRS models, which enables <...>" and then the next bullet points are the additional tools provided in the package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in last commit. Should I include dataproxy or nah?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@korikuzma korikuzma requested a review from theferrit32 April 3, 2024 11:22
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@larrybabb larrybabb merged commit 69d3ed3 into main Apr 4, 2024
8 checks passed
@larrybabb larrybabb deleted the issue-368 branch April 4, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to documentation only priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create or replace quick setup readme
4 participants