-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update + reorganize readme #376
Conversation
Co-authored-by: James Stevenson <james.sharpsteen@gmail.com>
|
||
- **ga4gh.core package** Python language support for certain nascent standards | ||
in GA4GH. Eventually, this package should be moved to a distinct repo. | ||
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@korikuzma I think the Features section should not be broken down by module. But instead it should be a bullet list of separate features (see hgvs read.me). I think it is harder to discern the specific features as it feels more technical to go through modules right out of the gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larrybabb should we be distinguishing between VRS Python features (ie the translator and annotator) and VRS features (a nonambiguous description of variation)? Or maybe bullet point one is like "Pydantic implementation of VRS models, which enables <...>" and then the next bullet points are the additional tools provided in the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in last commit. Should I include dataproxy or nah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
close #368
Ideally, in the future we will create a rtd so that our readme isn't so long