Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enum for core/vrs types #309

Closed
korikuzma opened this issue Jan 4, 2024 · 5 comments · Fixed by #420
Closed

Create enum for core/vrs types #309

korikuzma opened this issue Jan 4, 2024 · 5 comments · Fixed by #420
Assignees
@korikuzma
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch enhancement New feature or request priority:low Low priority

Comments

@korikuzma
Copy link
Contributor

In downstream apps, we are hard coding core/vrs model types. It would be nice if we could create a StrEnum for CoreTypes and VrsTypes that we could use.
@korikuzma korikuzma added enhancement New feature or request 2.0-alpha Issues related to VRS 2.0-alpha branch priority:low Low priority labels Jan 4, 2024
@sivangbagri
Copy link
Contributor

@korikuzma Hii , can I work on this issue?

@korikuzma
Copy link
Contributor Author

@sivangbagri sure

@sivangbagri
Copy link
Contributor

@korikuzma Hii can u guide in how should begin for this issue ? Particularly on which files should I work on

@korikuzma
Copy link
Contributor Author

Hi @sivangbagri please work off the main branch. Branch names were updated recently. You will need to use the models module for both core and vrs.

@korikuzma
Copy link
Contributor Author

@sivangbagri I haven't heard any updates, so I'll go ahead and work on this since it would be something nice to have for our projects

@korikuzma korikuzma self-assigned this Jul 10, 2024
korikuzma added a commit that referenced this issue Jul 10, 2024
@korikuzma
feat: create enum for gks-common + vrs types
d5bcaf5 
close #309
@korikuzma korikuzma mentioned this issue Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
2.0-alpha Issues related to VRS 2.0-alpha branch enhancement New feature or request priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create enum for gks-common + vrs types ga4gh/vrs-python
2 participants
@korikuzma @sivangbagri