Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do away with "private" modules #407

Closed
jsstevenson opened this issue May 10, 2024 · 1 comment · Fixed by #421 or #423
Closed

Do away with "private" modules #407

jsstevenson opened this issue May 10, 2024 · 1 comment · Fixed by #421 or #423
Assignees
@korikuzma
Labels
enhancement New feature or request priority:low Low priority

Comments

@jsstevenson
Copy link
Contributor

Models currently live within _internal modules, which sort of designates them as quote-unquote "private" unless they're imported into parent modules via __init__.py. I'm not sure this is a necessary organizational method, and it might be cleaner to do away with this separation.
@jsstevenson jsstevenson added enhancement New feature or request priority:low Low priority labels May 10, 2024
@korikuzma
Copy link
Contributor

I'll take a stab at this to see if we can get it in the latest release

@korikuzma korikuzma self-assigned this Jul 10, 2024
korikuzma added a commit that referenced this issue Jul 10, 2024
@korikuzma
refactor: remove _internal directories
456b744 
close #407

* Remove _internal directories and move files up a directory
@korikuzma korikuzma mentioned this issue Jul 10, 2024
Merged
korikuzma added a commit that referenced this issue Jul 10, 2024
@korikuzma
refactor: remove _internal directories (#421)
5c1a9d4 
close #407

* Remove _internal directories and move files up a directory
@korikuzma korikuzma mentioned this issue Jul 10, 2024
Merged
korikuzma added a commit that referenced this issue Jul 10, 2024
@korikuzma
refactor: remove _internal directories (#423)
57d472e 
close #407

Remove _internal directories and move files up a directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:low Low priority
Projects
None yet
Milestone
No milestone
2 participants
@jsstevenson @korikuzma