Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#113: update VRS-Python with VRS Genotype model #114

Merged
merged 2 commits into from
Nov 2, 2022
Merged

#113: update VRS-Python with VRS Genotype model #114

merged 2 commits into from
Nov 2, 2022

Conversation

ahwagner
Copy link
Member

@ahwagner ahwagner commented Oct 8, 2022

This PR addresses #113 and adds supporting example notebooks.

@korikuzma
Copy link
Contributor

Once this PR gets merged, we should update the VRS submodules and we should be good to merge.

@korikuzma korikuzma marked this pull request as ready for review October 26, 2022 14:56
@korikuzma
Copy link
Contributor

@ahwagner tests now pass. You said you'd work on genotype notebook? Should we create a new issue for this or do you want to work off this PR?

@ahwagner
Copy link
Member Author

I've added #117 as a separate issue to address later this week.

Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it.

@ahwagner ahwagner merged commit 5f699ed into main Nov 2, 2022
@korikuzma korikuzma deleted the issue-113 branch November 3, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants