feat!: update vrs 2.0-alpha models #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made use of the classes in core-source/vrs-source so we don't repeat code * Tried to reorganize some models * Update tests since digests changed
korikuzma
added
2.0-alpha
theferrit32
reviewed
Sep 12, 2023
| @@ -329,8 +498,7 @@ class SequenceLocation(BaseModel): | |||
| description='The end coordinate or range of the SequenceLocation. The minimum value of this coordinate or range is 0. MUST represent a coordinate or range greater than the value of `start`.', | |||
| ) | |||
|
|
|||
| class ga4gh: | |||
| identifiable = True | |||
| class ga4gh(_Ga4ghIdentifiableObject.ga4gh): | |||
There was a problem hiding this comment.
Originally I put these properties in a nested class in order for them to not be seen as related to the top level pydantic properties but still be declared on and accessible on the class. This change seems fine to share some of the structure of the .ga4gh nested classes, but if we can think of a cleaner way that'd also be nice.
There was a problem hiding this comment.
Hmmmm @toneillbroad do you have any suggestions? If not, we can make a separate issue for this and come back to it
There was a problem hiding this comment.
The structures as represented in this PR are good by me.
theferrit32
reviewed
Sep 12, 2023
theferrit32
approved these changes
Sep 12, 2023
toneillbroad
approved these changes
Sep 12, 2023
theferrit32
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
SequenceReference