Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memoization to data proxy methods to improve performance #304

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Add memoization to data proxy methods to improve performance #304

merged 3 commits into from
Dec 22, 2023

Conversation

ehclark
Copy link
Contributor

@ehclark ehclark commented Dec 21, 2023

See #303

Implemented functools.lru_cache decorator to the get_sequence and get_metadata methods of _SeqRepoDataProxyBase.

@ehclark ehclark requested review from a team as code owners December 21, 2023 21:47
larrybabb
larrybabb approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@larrybabb
Copy link
Contributor

keep them coming!

@larrybabb larrybabb merged commit 1a25095 into 2-alpha Dec 22, 2023
8 checks passed
@korikuzma korikuzma deleted the feature/data-proxy-memoization branch January 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larrybabb larrybabb larrybabb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehclark @larrybabb