Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test image for uta #313

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore: update test image for uta #313

merged 1 commit into from
Jan 8, 2024

Conversation

korikuzma
Copy link
Contributor

Part of #312

@korikuzma korikuzma added priority:low Low priority chore Changes that do not relate to a fix or feature and don't modify src or test files labels Jan 8, 2024
@korikuzma korikuzma self-assigned this Jan 8, 2024
@korikuzma korikuzma requested review from a team as code owners January 8, 2024 15:33
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@korikuzma korikuzma merged commit 8bf13d9 into 0.8 Jan 8, 2024
8 checks passed
@korikuzma korikuzma deleted the issue-312-docker branch January 8, 2024 15:52
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one README.md change to sync.

# psql -XAt postgres://anonymous@localhost/uta -c 'select count(*) from transcript'
# 249909
image: biocommons/uta:uta_20180821
# psql -XAt postgres://anonymous@localhost/uta -c 'select count(*) from uta_20210129b.transcript'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the corresponding documentation on the README.md should be changed as well (this took me a minute when I was trying to use the install instructions to figure out.

snafu$ psql -XAt postgres://anonymous@localhost/uta -c 'select count(*) from transcript'
249909

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess I missed the review window ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not relate to a fix or feature and don't modify src or test files priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants