feat: add param to VCFAnnotator to optionally require validation checks #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `require_validation` parameter. If `True`, validation checks must pass in order to return a VRS object. If validation checks fail, a ValueError will be raised. If `False`, then the VRS object will be returned even if validation checks fail.
|
@quinnwai I don't have permissions to change your permissions so you can be added as a reviewer. |
korikuzma
added
enhancement
quinnwai
suggested changes
Feb 14, 2024
|
Tested with a small vcf that...
Added an open question on the CLI code |
quinnwai
approved these changes
Feb 14, 2024
|
@ga4gh/vrs-python-maintainers Is someone able to review this so I can make a pypi release for @quinnwai? |
larrybabb
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #343
require_validationparameter. IfTrue, validation checks must pass in order to return a VRS object. If validation checks fail, a ValueError will be raised. IfFalse, then the VRS object will be returned even if validation checks fail.