Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 351.2 #353

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Issue 351.2 #353

merged 6 commits into from
Feb 23, 2024

Conversation

ahwagner
Copy link
Member

Addresses #351 as well as #352 (comment).

@ahwagner ahwagner requested review from a team as code owners February 23, 2024 06:00
larrybabb
larrybabb approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@larrybabb larrybabb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahwagner sorry I missed this issue on #352. Your logic looks good as far as I can tell. I am going to go ahead and merge this and assume @ehclark will respond if there are still open issues (in the name of expediency).

@larrybabb larrybabb merged commit 5a9115c into main Feb 23, 2024
8 checks passed
@larrybabb larrybabb deleted the issue-351 branch February 23, 2024 13:30
ehclark
ehclark reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@ehclark ehclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ahwagner. I ran several thousand random ins, del and delins tests and did not find any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehclark ehclark ehclark left review comments

@larrybabb larrybabb larrybabb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahwagner @larrybabb @ehclark