feat!: parameterize normalize in translator #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new kwarg (do_normalize) in translate_from methods. Set to determine if normalization should be performed
korikuzma
added
enhancement
larrybabb
reviewed
Mar 12, 2024
There was a problem hiding this comment.
@korikuzma please verify my understanding that this change is really making sure that a deverloper can more easily turn off the default 'normalization' processing if desired. Whereas prior to this PR that would have been less straight forward.
larrybabb
approved these changes
Mar 12, 2024
@larrybabb Correct. This is similar to #214 (default assembly name). It doesn't change the functionality, but makes it easier to switch without having to constantly re-set the instance variable. |
ehclark
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #231
@larrybabb I believe this will help with the variation-normalizer issue.