Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: fix release when multiple branches track same tag #384

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

korikuzma
Copy link
Contributor

@korikuzma korikuzma commented Apr 4, 2024

Our current approach can break when there are multiple branches that track the same tag:

$ echo $raw
origin/issue-380 origin/main origin/pypi-release-action origin/release origin/vcf-annotator-readme-update
$ branch=${raw##*/}
$ echo $branch
vcf-annotator-readme-update

@theferrit32 thanks for pointing out the multiple branches issue! I think this will fix the release action

@korikuzma korikuzma added bug Something isn't working priority:high High priority ci/cd Continuous integration and continuous delivery/deployment changes labels Apr 4, 2024
@korikuzma korikuzma self-assigned this Apr 4, 2024
@korikuzma korikuzma requested review from a team as code owners April 4, 2024 22:51
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korikuzma can you leave a brief (1 sentence apiece) description of the problem and the solution in the commit description when you squash? I think some of the innards of this github action can be a little opaque

@korikuzma korikuzma merged commit 6066b4a into main Apr 5, 2024
8 checks passed
@korikuzma korikuzma deleted the pypi-release-action branch April 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd Continuous integration and continuous delivery/deployment changes priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants