build: configure build with pyproject.toml #388
Conversation
| # which requires packaging changes. Deferred. | ||
| testpaths = src tests | ||
| doctest_optionflags = ALLOW_UNICODE ALLOW_BYTES ELLIPSIS IGNORE_EXCEPTION_DETAIL NORMALIZE_WHITESPACE | ||
| addopts = --cov-config=setup.cfg --cov-report=term-missing --cov=ga4gh |
There was a problem hiding this comment.
setup.cfg is given as the pytest-cov config target but no actual configuration options are set. I just removed this option from the corresponding line in pyproject.toml.
| # http://pep8.readthedocs.org/en/latest/intro.html#error-codes | ||
| [flake8] | ||
| max-line-length = 120 | ||
| exclude = tests/* | ||
| max-complexity = 10 | ||
| ignore = E129,E221,E241,E251,E303,W291 |
There was a problem hiding this comment.
Didn't add as a separate .flake8 file because flake8 isn't ever installed as part of dev dependencies
| [bdist_wheel] | ||
| universal = 1 |
There was a problem hiding this comment.
This is for retaining compatibility with Python 2 (https://wheel.readthedocs.io/en/stable/user_guide.html#building-wheels) -- we can remove it
| [aliases] | ||
| test = pytest |
There was a problem hiding this comment.
I don't believe there is a direct pyproject.toml equivalent of this, but it also doesn't seem to be used by the Makefile, so I left it out
| {name = "Larry Babb", email = "lbabb@broadinstitute.org"}, | ||
| {name = "Reece Hart", email = "reecehart@gmail.com"}, | ||
| {name = "Andreas Prlic", email = "andreas.prlic@gmail.com"}, | ||
| {name = "Alex Wagner", email = "alex.wagner@nationwidechildrens.org"}, |
There was a problem hiding this comment.
previously this was just Reece, but I went with all of the former and current VR heads for the sake of consistency
jsstevenson
changed the title
* In #388 we forgot to update the commands to remove setup.py since it was removed. This commit removes references to setup.py and setup.cfg in Makefile
I am not sure I can test that this produces a totally valid release, because
setuptools_scmwill render a version number that is incompatible with PyPI if you do so from a commit that doesn't have a version tag on it. I'm pretty sure it's correct, though.