-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tested and updated README.rst for MacOS 10.14.3 using python 3.7 #4
Conversation
Paul- The file additions are all for your local virtual environment, which should not be part of the repo. Please remove Thanks! |
Reece, |
You appear to have closed the PR. Was that intentional? If it's closed, I
can't merge it!
|
Oh, that was not my meaning! Sorry! I think that I've reopened the pull request, but I'm not very experienced with this. Please let me know if I'm doing something wrong. |
So i'm confused. Can I close this pull request now? |
Hi @poglesbyg- I appreciate your eagerness to contribute! With the allele registry commit, you've essentially combined two distinct features or changes into a single PR. PRs should contain discrete changes that do one thing. So, I'm going to close this PR unmerged. I will manually add the README change. Also, since vmc-python is a work in progress, the code will move fast and sometimes a bit chaotically. I am not ready to accept frequent PRs. When the project is further along, I'll be happy to accept changes. -Reece |
Reece-
If you want help, or need contributors let me know. Good luck!
…-Paul
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Reece Hart <notifications@github.com>
Sent: Tuesday, March 19, 2019 5:51 PM
To: ga4gh/vmc-python
Cc: Grant, Paul Oglesby; State change
Subject: Re: [ga4gh/vmc-python] Tested and updated README.rst for MacOS 10.14.3 using python 3.7 (#4)
Hi @poglesbyg-
I appreciate your eagerness to contribute!
With the allele registry commit, you've essentially combined two distinct features or changes into a single PR. PRs should contain discrete changes that do one thing. So, I'm going to close this PR unmerged. I will manually add the README change.
Also, since vmc-python is a work in progress, the code will move fast and sometimes a bit chaotically. I am not ready to accept frequent PRs. When the project is further along, I'll be happy to accept changes.
-Reece
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABgZr5kK1jvqo4R5kX2Zc-fqGJUqLIa2ks5vYVvegaJpZM4b6aFu>.
|
Hi, I've installed and tested this package using MacOS 10.14.3 using python 3.7. Please let me know if you need me to specify anything else.