Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested and updated README.rst for MacOS 10.14.3 using python 3.7 #4

Closed
wants to merge 7 commits into from

Conversation

poglesbyg
Copy link

Hi, I've installed and tested this package using MacOS 10.14.3 using python 3.7. Please let me know if you need me to specify anything else.

@reece
Copy link
Member

reece commented Mar 19, 2019

Paul-
Thanks for the PR. I appreciate the changes to the README.

The file additions are all for your local virtual environment, which should not be part of the repo.

Please remove bin/, commit, and push again. Your PR will be automatically updated.

Thanks!

@poglesbyg
Copy link
Author

Reece,
Thanks for a cool project. I've removed bin/ and recommitted. Please let me know if there is anything else I can do to help. I'd like to get more involved.
Best,
Paul

@poglesbyg poglesbyg closed this Mar 19, 2019
@reece
Copy link
Member

reece commented Mar 19, 2019 via email

@poglesbyg poglesbyg reopened this Mar 19, 2019
@poglesbyg
Copy link
Author

poglesbyg commented Mar 19, 2019

Oh, that was not my meaning! Sorry! I think that I've reopened the pull request, but I'm not very experienced with this. Please let me know if I'm doing something wrong.

@poglesbyg poglesbyg closed this Mar 19, 2019
@poglesbyg poglesbyg reopened this Mar 19, 2019
@poglesbyg
Copy link
Author

So i'm confused. Can I close this pull request now?

@reece
Copy link
Member

reece commented Mar 19, 2019

Hi @poglesbyg-

I appreciate your eagerness to contribute!

With the allele registry commit, you've essentially combined two distinct features or changes into a single PR. PRs should contain discrete changes that do one thing. So, I'm going to close this PR unmerged. I will manually add the README change.

Also, since vmc-python is a work in progress, the code will move fast and sometimes a bit chaotically. I am not ready to accept frequent PRs. When the project is further along, I'll be happy to accept changes.

-Reece

@reece reece closed this Mar 19, 2019
@poglesbyg
Copy link
Author

poglesbyg commented Mar 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants