Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename core_models to common_models #413

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat!: rename core_models to common_models #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fefbfc
feat!: rename core_models to common_models
korikuzma Jun 20, 2024
89b2b72
Merge branch 'main' into issue-412
korikuzma Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ga4gh/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from ._internal.pydantic import (
is_pydantic_instance, is_curie_type, is_ga4gh_identifiable, is_literal, pydantic_copy
)
from ._internal import models as core_models
from ._internal import models as common_models

try:
__version__ = version(__name__)
Expand Down
6 changes: 3 additions & 3 deletions src/ga4gh/core/_internal/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

Instead, users should use one of the following:

* `from ga4gh.core import core_models`, and refer to models with the
abbreviated name, e.g., `core_models.Gene` (recommended)
* `from ga4gh.core import common_models`, and refer to models with the
abbreviated name, e.g., `common_models.Gene` (recommended)

* `import ga4gh.core`, and refer to models using the fully-qualified
module name, e.g., `ga4gh.core.core_models.Gene`
module name, e.g., `ga4gh.core.common_models.Gene`
"""
from typing import Any, Dict, List, Literal, Optional, Union, Annotated
from enum import Enum
Expand Down
Loading