feat: add enum for as_version + add restrictions to ga4gh_serialize_as_version
#431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze_as_version` Building off of #382 and #427 * Add `PrevVrsVersion` enum to store previous versions of VRS that is supported for computing digests/identifiers * Updates function signatures + docstrings for ga4gh digest/serialize/identifier * Adds restrictions to `ga4gh_serialize_as_version` * For `SequenceLocation`: `sequenceReference` must be provided and must be a valid `SequenceReference` obj * For `Allele`: Only `LiteralSequenceExpression` and `ReferenceLengthExpression` are supported and must provide a `sequence` nonnull attribute.
korikuzma
added
enhancement
korikuzma
changed the title
as_version + add restrictions to `ga4gh_seriali…as_version + add restrictions to ga4gh_serialize_as_version
korikuzma
commented
Jul 16, 2024
korikuzma
commented
Jul 16, 2024
Comment on lines
+68
to
+72
| @classmethod | ||
| def validate(cls, version): | ||
| if version is not None and version not in cls.__members__.values(): | ||
| err_msg = f"Expected `PrevVrsVersion`, but got {version}" | ||
| raise ValueError(err_msg) |
There was a problem hiding this comment.
I was going back and forth on moving this to a function rather than classmethod. I'm fine with whichever.
korikuzma
changed the title
as_version + add restrictions to ga4gh_serialize_as_versionas_version + add restrictions to ga4gh_serialize_as_version
ahwagner
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #382 and #427
PrevVrsVersionenum to store previous versions of VRS that is supported for computing digests/identifiersga4gh_serialize_as_versionSequenceLocation:sequenceReferencemust be provided and must be a validSequenceReferenceobjAllele: OnlyLiteralSequenceExpressionandReferenceLengthExpressionare supported and must provide asequencenonnull attribute.