fix: ensure Entity objects return type as str #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
approved these changes
Jul 17, 2024
jsstevenson
reviewed
Jul 17, 2024
src/ga4gh/core/domain_models.py
Outdated
|
|
||
| from pydantic import Field, RootModel | ||
|
|
||
| from ga4gh.core.entity_models import DomainEntity | ||
|
|
||
|
|
||
| class CommonDomainType(str, Enum): | ||
| class CommonDomainType: |
jsstevenson
approved these changes
Jul 17, 2024
|
@jsstevenson I reverted back to str, Enum because I think it makes more sense. We do not want people to be able to reassign these values (whether on purpose or accident) in downstream apps. Lmk if you disagree and I can revert last commit to go back to simple class constant. |
jsstevenson
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #433
use_enum_valuesconfig . I removed in feat!: update vrs/common models #417 because of a copy/paste I had done in the Adjacency class which left me confused.typefield should be a literal string, not enum