Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enhance annotator CLI options #449

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Sep 3, 2024

  • Make the input VCF path an argument rather than an option. I think this better matches the intent of the tool (and it was the only required option, so might as well make it an arg, right?). Left it at nargs=1 but I think there's a case for making it nargs=-1... but going 1 -> -1 wouldn't be a breaking change imo so I think it's fine to put that decision off.
  • pathlike args should be click.Path/pathlib.Path. Add additional configurations, like the input file must exist and the output files must be writable. Didn't make changes further up the stack because I wanted to confine this PR to just the Click interface.
  • remove some superfluous/inactive configs
  • Touch up help text

@jsstevenson jsstevenson added the priority:low Low priority label Sep 3, 2024
@jsstevenson jsstevenson marked this pull request as ready for review September 3, 2024 18:27
@jsstevenson jsstevenson requested review from a team as code owners September 3, 2024 18:27
@jsstevenson jsstevenson merged commit 456cd38 into main Sep 3, 2024
6 checks passed
@jsstevenson jsstevenson deleted the click-option-fixes branch September 3, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants