Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seqref updates #573

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Draft

Seqref updates #573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0745ccc
addresses #568
ahwagner Oct 28, 2024
cd9fe2c
addresses #567
ahwagner Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions schema/vrs/vrs-source.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,17 @@ $defs:
enum:
- aa
- na
sequence:
type:
$ref: "#/$defs/SequenceString"
description: >-
A :ref:`SequenceString` that is a literal representation of the referenced sequence.
moleculeType:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmprocknow concern about "molecule type"; perhaps "molecularContext" would be cleaner.

type: string
enum:
- genomic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general discussion on genomic expressed concerns, possible alternate is "template"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except "template" is a total non-starter. There are genomic variants that are not necessarily going to be involved as template sequence (e.g. variants in regulatory elements)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group consensus: we should cover the same concept types that RefSeq uses.

- transcript
- protein
circular:
type: boolean
description: >-
Expand Down
Loading