RunDescription and RunStatus are identical - should they be collapsed?

[geoffjentry]

Curious if anyone had thoughts on this.

For practical purposes RunStatus and RunDescription appear to be the same. Does anyone oppose collapsing them into a single entity?

@tetron @mckinsel @jaeddy ?

[mckinsel]

Seems fine to me; I think they're exactly the same?

[geoffjentry]

Technically they're not as one of them declares both fields as REQUIRED and one doesn't, but I can't imagine it ever being used otherwise in practical terms. I'm just going to open a PR instead of philosophizing here and then going through it again in PR form

[jaeddy]

Good catch, @geoffjentry. Not sure if RunDescription is ever used, and there's a GetRunStatus operation, so I'd vote for keeping that object. RunStatus seems to be missing a description/title, so maybe steal that from RunDescription before collapsing.

[geoffjentry]

@jaeddy RunDescription gets used as part of a RunListResponse which in turn gets returned by /runs GET. Discovered that as I was fixing up our endpoints and noticed I had two identical classes :)

You're right that a proper merge of the two seems to be the best course as both have informational bits that the other does not, despite being structurally identical. I'll open a PR later today and link it to this issue