[Explore] Refresh chart overlay when chart is out of sync with control panel #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allowing config flag to turn off javascript controls * lint * one line, avoiding mutation * Setting JS fields as readOnly
recent regression perhaps from the PR that moved to using POST .
* [hotfix] resolve utf-8 encoding issue in db migration * make python string unicode * Update e866bd2d4976_smaller_grid.py * Update e866bd2d4976_smaller_grid.py * rearrange the debug message * Update e866bd2d4976_smaller_grid.py
|
This is super cool!! 🎉 I like the designs Chris had where the opacity is changed in the chart itself. What do you think of that instead of the dark overlay?
|
|
I second @michellethomas's comment regarding opacity. |
|
@michellethomas @john-bodley Sounds good to me 👍 I'll make that change |
|
cc @michellethomas @john-bodley updated overlay to cause the graph to fade out a bit. |
|
this looks really good 🎉 |
gabe-lyons
force-pushed
the
gabe_highlighting_run_query_when_chart_is_stale
branch
from
6c00401
to
584994c
Compare
* Make filterbox i18n * Change double-quote to single-quote in localization function t() to pass lint test * Updated .po file with italian translation. New strings generated and translated via babel-extract
…pache#4459) * highlighting run query when chart is stale on explore view * refactoring control changed code
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
from
7e3e7aa
to
a0ecc2e
Compare
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
from
a0ecc2e
to
c96ef64
Compare
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
2 times, most recently
from
a9d2616
to
9cb7d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to apache#4459 to make it more obvious when the chart should be refreshed.
no changes looks like this:
after making a change affecting the query:
but if you make a change causing errors:
