chore(ifdata): Clean up function params

cmd/ifdata/cmd.go

@@ -164,8 +164,11 @@ func run(cmd *cobra.Command, args []string) error {
 	}
 
 	for _, iface := range ifaces {
-		s, err := format.Sprint(cmd, iface)
+		s, err := format.Sprint(iface)
 		if err != nil {
+			if errors.Is(err, ErrUnknownFormatter) {
+				cmd.SilenceUsage = false
+			}
 			errs = append(errs, err)
 			continue
 		}

cmd/ifdata/formatter.go

@@ -7,8 +7,6 @@ import (
 	"slices"
 	"strconv"
 	"strings"
-
-	"github.com/spf13/cobra"
 )
 
 //go:generate go run github.com/dmarkham/enumer -type formatter -linecomment -output formatter_string.go
@@ -123,7 +121,7 @@ func (f formatter) supported() bool {
 
 var ErrUnknownFormatter = errors.New("unknown formatter")
 
-func (f formatter) Sprint(cmd *cobra.Command, iface *net.Interface) (string, error) {
+func (f formatter) Sprint(iface *net.Interface) (string, error) {
 	switch f {
 	case fmtMTU:
 		return strconv.Itoa(iface.MTU), nil
@@ -163,10 +161,8 @@ func (f formatter) Sprint(cmd *cobra.Command, iface *net.Interface) (string, err
 		return strings.TrimSpace(buf.String()), nil
 	default:
 		if f.supported() {
-			return f.formatStatistics(cmd, iface)
+			return f.formatStatistics(iface)
 		}
-
-		cmd.SilenceUsage = false
 		return "", fmt.Errorf("%w: %s", ErrUnknownFormatter, f)
 	}
 }

cmd/ifdata/statistics_darwin.go

@@ -8,16 +8,14 @@ import (
 	"strconv"
 	"time"
 
-	"github.com/spf13/cobra"
 	"golang.org/x/sys/unix"
 )
 
 const statisticsSupported = true
 
-func (f formatter) formatStatistics(cmd *cobra.Command, iface *net.Interface) (string, error) {
+func (f formatter) formatStatistics(iface *net.Interface) (string, error) {
 	format := statsFormatter(f)
 	if format == nil {
-		cmd.SilenceUsage = false
 		return "", fmt.Errorf("%w: %s", ErrUnknownFormatter, f)
 	}
 

cmd/ifdata/statistics_linux.go

@@ -7,15 +7,13 @@ import (
 	"time"
 
 	"github.com/prometheus/procfs"
-	"github.com/spf13/cobra"
 )
 
 const statisticsSupported = true
 
-func (f formatter) formatStatistics(cmd *cobra.Command, iface *net.Interface) (string, error) {
+func (f formatter) formatStatistics(iface *net.Interface) (string, error) {
 	format := statsFormatter(f)
 	if format == nil {
-		cmd.SilenceUsage = false
 		return "", fmt.Errorf("%w: %s", ErrUnknownFormatter, f)
 	}
 

cmd/ifdata/statistics_unsupported.go

@@ -2,14 +2,10 @@
 
 package ifdata
 
-import (
-	"net"
-
-	"github.com/spf13/cobra"
-)
+import "net"
 
 const statisticsSupported = false
 
-func (f formatter) formatStatistics(_ *cobra.Command, _ *net.Interface) (string, error) {
+func (f formatter) formatStatistics(_ *net.Interface) (string, error) {
 	return "", ErrStatisticsUnsupported
 }