Skip to content

Commit

Permalink
Fix #1302
Browse files Browse the repository at this point in the history
  • Loading branch information
gabime committed Nov 8, 2019
1 parent ff3e6c7 commit 844d54d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/spdlog/details/os-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ SPDLOG_INLINE bool in_terminal(FILE *file) SPDLOG_NOEXCEPT
#if (defined(SPDLOG_WCHAR_TO_UTF8_SUPPORT) || defined(SPDLOG_WCHAR_FILENAMES)) && defined(_WIN32)
SPDLOG_INLINE void wstr_to_utf8buf(wstring_view_t wstr, memory_buf_t &target)
{
if (wstr.size() > static_cast<size_t>(std::numeric_limits<int>::max()))
if (wstr.size() > static_cast<size_t>((std::numeric_limits<int>::max())))

This comment has been minimized.

Copy link
@mmakhalaf

mmakhalaf Nov 9, 2019

Instead of (std::numeric_limits<int>::max()), this works for me (std::numeric_limits<int>::max)(). I haven't run this code yet but looks like the brackets were added around the whole expression (not the function name)?

This comment has been minimized.

Copy link
@gabime

gabime Nov 9, 2019

Author Owner

Thanks. Fixed again

{
SPDLOG_THROW(spdlog::spdlog_ex("UTF-16 string is too big to be converted to UTF-8"));
}
Expand Down

0 comments on commit 844d54d

Please sign in to comment.