Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt.o should not be compiled when using external fmt library #1273

Closed
dvhwgumby opened this issue Oct 19, 2019 · 2 comments
Closed

fmt.o should not be compiled when using external fmt library #1273

dvhwgumby opened this issue Oct 19, 2019 · 2 comments
Assignees
@gabime

Comments

@dvhwgumby
Copy link

SPDLOG_SRCS should not include src/fmt.cpp unless SPDLOG_FMT_EXTERNAL=OFF . Its contents are correctly protected from compilation via preprocessor in this case, but compiling that file causes ranlib to complain ranlib: file: libspdlog.a(fmt.cpp.o) has no symbols.

Seems like this is a small oversight as installation already takes care not to include include fmt/bundled
@gabime
Copy link
Owner

gabime commented Oct 19, 2019

Agreed. Thanks for reporting.

@gabime gabime self-assigned this Oct 19, 2019
@gabime gabime closed this as completed in fbb3f41 Oct 20, 2019
@gabime
Copy link
Owner

gabime commented Oct 20, 2019

Fixed.

bachittle pushed a commit to bachittle/spdlog that referenced this issue Dec 22, 2022
@esigo
install sdk config (gabime#1273)
e072daa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabime gabime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvhwgumby @gabime