Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Order of includes matters #2082

Closed
tiolan opened this issue Aug 31, 2021 · 2 comments
Closed

[Minor] Order of includes matters #2082

tiolan opened this issue Aug 31, 2021 · 2 comments

Comments

@tiolan
Copy link
Contributor

tiolan commented Aug 31, 2021

Using v1.8.1 the order of includes is important.
If I (alphabetically sorted)

#include <spdlog/fmt/bin_to_hex.h>
#include <spdlog/spdlog.h>

I get size_t not defined and a lot other issues.

But if I

#include <spdlog/spdlog.h>
#include <spdlog/fmt/bin_to_hex.h>

it works fine.

Not sure if this is to be considered a bug, but people tend to say the order of includes should not matter.

@gabime
Copy link
Owner

gabime commented Aug 31, 2021

I think it is already fixed in pr #2035

@tiolan
Copy link
Contributor Author

tiolan commented Aug 31, 2021

I just found this PR that I seemed to miss before.

@tiolan tiolan closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants