bin_to_hex.h: include spdlog.h #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n any order with spdlog.h
|
Thanks. I think including common.h is sufficiant. |
gabime
requested changes
Aug 9, 2021
Done |
|
Thanks @dmerkushov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to support inclusion of
bin_to_hex.hin any order withspdlog.hPROBLEM FIXED (UNWANTED COMPILATION BEHAVIOR):
Some projects require sorting inclusions in alphabetical order. But in case one includes
<spdlog/fmt/bin_to_hex.h>prior to<spdlog/spdlog.h>, multiple compilation errors arise:bin_to_hex.h:35:45: error: ‘size_t’ has not been declaredbin_to_hex.h:59:42: error: ‘begin’ is not a member of ‘std’bin_to_hex.h:59:65: error: ‘end’ is not a member of ‘std’bin_to_hex.h:83:5: error: ‘FMT_CONSTEXPR’ does not name a typebin_to_hex.h:115:9: error: ‘SPDLOG_CONSTEXPR’ was not declared in this scopeand so on...
(My compiler is GCC 10.3)
This PR adds an include of
spdlog.hintobin_to_hex.h, so they can be included in any order.