Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deadlock on filename() call #1571

Merged
merged 2 commits into from
May 26, 2020
Merged

fix deadlock on filename() call #1571

merged 2 commits into from
May 26, 2020

Conversation

IIFE
Copy link
Contributor

@IIFE IIFE commented May 26, 2020

Fixes #1570

  • rotating-file-sink was not actually using filename() at all anyway, so remove.
  • daily-file-sink can just use file_helper_.filename()

gabime
gabime requested changes May 26, 2020
View reviewed changes
Copy link
Owner

@gabime gabime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename() functions should not be removed. They are part of the official API.

The fix is just a single line

 filename_t current_file = file_helper_.filename();

@IIFE
Copy link
Contributor Author

IIFE commented May 26, 2020

Didn't realise they were public. Put them back.

@gabime gabime merged commit ac19803 into gabime:v1.x May 26, 2020
@tt4g tt4g mentioned this pull request Mar 29, 2021
Closed
@tt4g tt4g mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabime gabime gabime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

daily_file_sink has deadlock bug
2 participants
@IIFE @gabime