-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build2 package support #1851
Conversation
WARNING: Please do not merge yet! See below. We are currently in the process of packaging `spdlog` for `build2`, we have it working (even on unsupported Windows, see for example: https://ci.stage.build2.org/@a993b64e-8ba2-422e-97d7-250cdb5828e0?builds=&pv=&tc=*&cf=&mn=&tg=&rs=*) This change simply adds the necessary information to use this package when using `build2`. Some notes: - not sure how to give the info succintly because `build2` allows packages to come from different sources, including the git repository of the package - in doubt I just linked to the future community repository address providing all the info, but the other package manager didn't do it like that so not sure if it's ok for you?; - `build2` distinguish the package (`depends: spdlog <some-version-scheme>`, added in the `manifest` file of a `build2` project) and the target (`spdlog%lib{spdlog}` imported in a `buildfile`) because packages can contain several targets. I was not sure how to formulate that here, so feel free to tell me if I should just provide the name of the package and not more info? The package isn't available yet so this have to be merged only once it is made available (probably in a few days).
what is build2? never heard of it |
It's a build-system combined with a package manager, see https://build2.org It's known to be one of the first buildsystem handling C++ modules (when preview implementations were made available), among other things. Once the package will be published, it will be available on https://cppget.org which is the OSS community central repository. But build2 also allows to use build2 packages/projects inside git repositories, so that's another option (when you want to use a tweaked version of the package for example). |
The build2 package for spdlog v1.8.2 is currently in the publication queue: https://queue.cppget.org/spdlog/1.8.2+1 Waiting for the publication to be done. |
What do you mean ? Windows is officially supported |
Sorry, I meant spdlog as shared library on Windows. |
You can merge this now if you want, or point me tweaks you would like me to do. |
It is not updated. Shared build is supported. |
@Klaim Something doesn't look right in the command example, so I reverted. |
@gabime There is no specific "command": you just add the package as dependency in your After that you can then import the It's similar to So here I just named the package and the target to import, similarly to the Or do I misunderstand what you want in there? |
so, maybe something like build2: |
Works for me. |
btw I am a big fan of cargo, so I really hope build2 succeeds! |
Nice :D I updated the branch, should I make another PR? |
No need. I already updated |
Thanks! |
WARNING: Please do not merge yet! See below.
We are currently in the process of packaging
spdlog
forbuild2
, we have it working (even on unsupported Windows, see for example: https://ci.stage.build2.org/@a993b64e-8ba2-422e-97d7-250cdb5828e0?builds=&pv=&tc=*&cf=&mn=&tg=&rs=*)This change simply adds the necessary information to use this package when using
build2
. Some notes:build2
allows packages to come from different sources, including the git repository of the package - in doubt I just linked to the future community repository address providing all the info, but the other package manager didn't do it like that so not sure if it's ok for you?;build2
distinguish the package (depends: spdlog <some-version-scheme>
, added in themanifest
file of abuild2
project) and the target (spdlog%lib{spdlog}
imported in abuildfile
) because packages can contain several targets. I was not sure how to formulate that here, so feel free to tell me if I should just provide the name of the package and not more info?The package isn't available yet so this have to be merged only once it is made available (probably in a few days).