CMake: Add SPDLOG_STATIC_VCRT to choose static MSVC runtime #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
approved these changes
Mar 4, 2021
|
Thanks! Merged |
|
@rofferom Needed to revert. Apparently it breaks builds with CMake versions prior to 3.15 |
|
Woops, I'll check how to update the patch. What is the minimum cmake version you target ? |
|
3.10 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a flag for Windows build to change the target runtime (
/MT//MD).The naming comes from SDL2's cmake: https://github.com/libsdl-org/SDL/blob/main/CMakeLists.txt#L226.
I based my tests with this doc: https://stackoverflow.com/a/19487637.