Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lower-case "windows.h" for case-sensitive file systems #2495

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Use lower-case "windows.h" for case-sensitive file systems #2495

merged 1 commit into from
Sep 26, 2022

Conversation

panicgh
Copy link
Contributor

@panicgh panicgh commented Sep 26, 2022

The "windows.h" in MinGW-W64 is lower-case. When cross-compiling for Windows on Linux with a case-sensitive file system, the upper-case "Windows.h" file is not found and compilation fails.

Always use lower-case "windows.h" to fix cross-compilation.

The "windows.h" in MinGW-W64 is lower-case. When cross-compiling for
Windows on Linux with a case-sensitive file system, the upper-case
"Windows.h" file is not found and compilation fails.

Always use lower-case "windows.h" to fix cross-compilation.
@gabime gabime merged commit 7130676 into gabime:v1.x Sep 26, 2022
@gabime
Copy link
Owner

gabime commented Sep 26, 2022

Thanks @panicgh

@panicgh panicgh deleted the lowercase-windows-h branch November 26, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants