dup_filter_sink adds parameters to enable setting the level of skipped logs #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
requested changes
Dec 1, 2022
| @@ -41,15 +41,17 @@ class dup_filter_sink : public dist_sink<Mutex> | |||
| { | |||
| public: | |||
| template<class Rep, class Period> | |||
| explicit dup_filter_sink(std::chrono::duration<Rep, Period> max_skip_duration) | |||
| explicit dup_filter_sink(std::chrono::duration<Rep, Period> max_skip_duration, level::level_enum level = level::info) | |||
There was a problem hiding this comment.
Please provide more descriptive name to this param. something like level::level_enum notification_level)
zydxhs
force-pushed
the
ftr_duplog_level
branch
from
31679b5
to
b8a64c0
Compare
|
Hi, param name is changed. |
|
Merged. Thanks @zydxhs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, dup_filter_sink uses the info level to output duplicate messages.In some scenarios, users don't care about the messages and want to keep them at a lower level so they can ignore them.