msvc_sink: support utf8 #2651
Merged
msvc_sink: support utf8 #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I don't think new cmake variable is needed. We can use the SPDLOG_WCHAR_TO_UTF8_SUPPORT variable, like in |
Demonese
force-pushed
the
develop_msvc_sink_utf8
branch
from
45b83a7
to
5e5d455
Compare
|
Thanks @Demonese |
seker
pushed a commit
to seker/spdlog
that referenced
this pull request
Mar 3, 2023
* msvc_sink: support utf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a workaround I'm using in my own project, about this issue: #2012.
This time I added an option for developers to decide whether to enable this feature.
I think this is very helpful for users who use Visual Studio but cannot modify the built-in debug output window encoding. I believe this improvement has reason to be merged.