Fix os namespace in systemd_sink.h #2668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2619 added
os::thread_id()
function calls tospdlog/sinks/systemd_sink.h
.But access to
os::thread_id()
is not valid, as the full namespace isspdlog::details::os
, while the current code is in the namespacespdlog::sinks
and thus the namespaceos::
is not directly accessible.As a side note: The test_systemd.cpp is currently not built in the pipeline, because it fails to find systemd in the cmake configuration step. Mabye it is sufficient to install the
libsystemd-dev
package in the container?